React test lambda destructuring #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original test implementation for the react test via #29 was specifying multiple constructors in order to specify different lambda parameter counts which allowed for a test to be written like:
reactor.ComputeCell(one, two) { x, y -> x + y * 10 }. The multiple constructor approach was ditched in favor of a single constructor but taking in a list into a lambda expression which resulted in a test of:reactor.ComputeCell(one, two) { it[0] + it[1] * 10 }Now that Kotlin 1.1 has come out (#38) we can provide a similar test syntax originally provided by using the new lambda destructuring capability to provide a test of:
reactor.ComputeCell(one, two) { (x, y) -> x + y * 10 }.