Add darts

[BNAndras]

No description provided.

[georgyo]

Looks pretty good to me!

Do you want to take a stab at creating a test generator for this one?

[BNAndras]

I'm having trouble running test_gen even though I have a local copy of problem specifications (see bottom).

My current template adapted from knapsack seems to get most of the way, but I manually converted the integral X and Y values into floats for simplicity. Is there a way I can reflect that in the template?

open Base
open OUnit2
open Darts

let ae exp got _test_ctxt =
  let printer = Int.to_string in
  assert_equal exp got ~printer

let tests = [
{{#cases}}
    "{{description}}" >::
    ae {{#input}}{{expected}} ({{property}} ({{x}}) ({{y}})){{/input}};
{{/cases}}
]

let () =
  run_test_tt_main ("darts tests" >::: tests)

Error message

Leaving directory '/home/anagy/Documents/GitHub/exercism-ocaml/test-generator'
Uncaught exception:                
  
  (Unix.Unix_error "No such file or directory" opendir
   "((dirname ./problem-specifications/exercises))")

Raised at Core_unix.improve in file "core_unix/src/core_unix.ml", line 45, characters 4-83
Called from Generator__Files.ls_dir in file "lib_generator/files.ml", line 22, characters 7-30
Called from Generator__Files.find_files in file "lib_generator/files.ml", lines 51-52, characters 2-11
Called from Generator__Controller.run in file "lib_generator/controller.ml", line 15, characters 4-73
Called from Dune__exe__Test_gen.command.(fun) in file "bin_test_gen/test_gen.ml", lines 42-47, characters 11-26
Called from Command.For_unix.run.(fun) in file "command/src/command.ml", lines 3388-3399, characters 8-31
Called from Base__Exn.handle_uncaught_aux in file "src/exn.ml", line 126, characters 6-10```

[kahgoh]

I think we could format the X and Y into floats by "editing" the cases in test-generator/lib_generator/special_cases.ml. I remember having to "edit" data to format the list of items in the knapsack PR #525 (the edit_knapsnack function). Let us know if you need further help.

[kahgoh]

Hey @BNAndras, just thought to ask how are you going with the handling the floats with template? Would you like me to have a look at it?

[BNAndras]

I've been dealing with family matters this week, but I can probably work on it later this week. The major issue is that I can't run the test generator at the moment (see up-thread) so I can't confirm what the generated tests look like.

[kahgoh]

Ok, no worries 😉

I just looked at the exception again and realized it says it can't find ./problem-specifications/exercises. I wonder if you missed the git submodule update --init --recursive step? (There is a problem-specifications Git submodule in the OCaml repository)

[BNAndras]

I was following the building section instructions, which didn't reference that. dune build ./bin_test_gen --profile=release works though after running your command. The built test_gen executable works up to forth, which should be fine in this case. However, test-generator/README.md doesn't give guidance on how to deal with special cases. It seems the intention is for me to add code to edit the incoming problem-specs JSON before it goes into the darts template.. So I should add an entry to edit_parameters for this slug since I want to update the x and y parameters. Then I handle how to to turn the ints into floats.

[BNAndras]

@kahgoh, I haven't been able to make progress so feel free to deal with the template generator. I figure you should add yourself as an exercise co-author at that point, but it's up to you.

[kahgoh]

Hey @BNAndras, I'm not quite sure what the best way of going about it is, but I've added the template on my branch (on top of your commits). I've also raised a PR BNAndras#1 into your branch if that's easier. Could you see if you pull / merge it your PR branch?

[BNAndras]

Normally, I’d just edit the branch for the PR directly, but I don’t know if that’s the preferred way.

[kahgoh]

Thanks! Looks good to me. Since I had a hand in writing the template, @georgyo could you please review?

[BethanyG]

@georgyo @kahgoh -- I don't have write access here, so can't merge. But this looks like it is ready ......