Do not assume default values #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures global consistency
|
Not knowledgeable about Perl style or things like that so I can't comment on that, but functionality looks good to me (test runs, and if I deliberately make a wrong impl test fails) so I'm 👍 on this. And using common data is good! |
|
@petertseng obviously I don't like the idea of merging my own PRs - who else has merge rights? |
|
Those who can merge other than you would either be @kytrinyx herself or those in https://github.com/orgs/exercism/teams/perl (if any other than you are still around, which we are not 100% sure of) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
This removes the assumption that the multiples default to 3 and 5 if not provided.