Skip to content

Fix issue 70, improve clock tests. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

petemcfarlane
Copy link
Contributor

No description provided.

@kytrinyx
Copy link
Member

kytrinyx commented Apr 8, 2016

Thanks, Pete. I can't remember the deal in the PHP track. Did we decide to remove the skips from the exercises?

@petemcfarlane
Copy link
Contributor Author

Nope, that’s my fault! I couldn’t get the makefile working so I was running the tests from the cli instead. I’ll correct that now!

On 8 Apr 2016, at 14:07, Katrina Owen [email protected] wrote:

Thanks, Pete. I can't remember the deal in the PHP track. Did we decide to remove the skips from the exercises?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #71 (comment)

@kytrinyx
Copy link
Member

kytrinyx commented Apr 8, 2016

Ah, let me see if I can figure out what's going on with the makefile.

@kytrinyx
Copy link
Member

kytrinyx commented Apr 8, 2016

Oh. Uh--the make file isn't actually running any tests at all on CI. I just fixed the same thing on the Ruby track this morning. Oops.

@petemcfarlane
Copy link
Contributor Author

Ahh good spot! I've fixed that in the last commit 976261d 👍

@kytrinyx
Copy link
Member

kytrinyx commented Apr 8, 2016

That travis run looks much better.

Would you mind sticking the makefile fix into a different PR? If you're on you way to work or something I can cherrypick it locally.

@petemcfarlane
Copy link
Contributor Author

Yup, I've moved it into PR #72

@kytrinyx
Copy link
Member

kytrinyx commented Apr 8, 2016

Sweet, thanks so much!

@kytrinyx kytrinyx merged commit a7e5a17 into exercism:master Apr 8, 2016
camilopayan pushed a commit to camilopayan/exercism-php that referenced this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants