-
-
Notifications
You must be signed in to change notification settings - Fork 141
Fix issue 70, improve clock tests. #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, Pete. I can't remember the deal in the PHP track. Did we decide to remove the skips from the exercises? |
Nope, that’s my fault! I couldn’t get the makefile working so I was running the tests from the cli instead. I’ll correct that now!
|
Ah, let me see if I can figure out what's going on with the makefile. |
Oh. Uh--the make file isn't actually running any tests at all on CI. I just fixed the same thing on the Ruby track this morning. Oops. |
69479e7
to
e4ec4eb
Compare
Ahh good spot! I've fixed that in the last commit 976261d 👍 |
That travis run looks much better. Would you mind sticking the makefile fix into a different PR? If you're on you way to work or something I can cherrypick it locally. |
976261d
to
e4ec4eb
Compare
Yup, I've moved it into PR #72 |
Sweet, thanks so much! |
Fix issue 70, improve clock tests.
No description provided.