Skip to content

largest-series-product: Canonical data has non-standard error indicator #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Insti opened this issue Aug 29, 2018 · 1 comment
Closed

Comments

@Insti
Copy link
Contributor

Insti commented Aug 29, 2018

The canonical data for the largest-series-product exercise has an expected value of -1 for the error cases.

The canonical data documentation says

If an error is expected (because the input is invalid, or any other reason), the value at "expected" should be an object containing exactly one property, "error", whose value is a string.

Todo:

Update the largest-series-product canonical-data.json to use the correct error format.

See also: hamming canonical-data.json for another example of how to do things the right way.

@Insti
Copy link
Contributor Author

Insti commented Sep 21, 2018

Thanks @sdublish ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant