Skip to content

scrabble-score: add tests for optional extensions? (:double/:triple letter values) #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juleskers opened this issue Jan 24, 2017 · 2 comments

Comments

@juleskers
Copy link
Contributor

In the scrabble-score exercise, there is the optional section to implement the double-letter-value mechanism. However, there are no tests to guide one when doing this.

I stumbled over this while implementing scrabble-score for the rust-track.
My pull-request against xrust was redirected here for broader discussion.

Should we add tests for this optional section? Or are those intentionally not included to encourage the exerciser to try his/her hand at test-writing?

@Insti
Copy link
Contributor

Insti commented Jan 25, 2017

Should we add tests for this optional section?

No

I also wrote about this here: #512 (comment)

The main problem that should be well described and covered by the canonical-data tests is just the word scoring.

The discussion about how to implement the extensions is part of the extended work and should not be specified in the problem description.

@juleskers
Copy link
Contributor Author

Thanks for the feedback! I'll stop work in that direction then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants