README.md: Document expected use of lowerCamelCase #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insti
reviewed
Nov 15, 2017
README.md
Outdated
| @@ -105,6 +105,7 @@ example, what kinds of implementation mistakes might this case help us find? | |||
|
|
|||
| There are also some convention about `expected` that you must follow: | |||
|
|
|||
| - all keys should follow [lowerCamelCase](http://wiki.c2.com/?LowerCamelCase) convention. | |||
There was a problem hiding this comment.
Looks good. 👍
Minor grammar issues:
All keys should follow the lowerCamelCase convention.
The following ifs lacking capital Is is a separate unrelated grammatical issue that this PR need not address.
There was a problem hiding this comment.
Changes made as requested.
|
Very good. I'll capitalize the sentence as you suggest and leave the others as is, for a future PR to deal with.
Thanks
Sent from my android device.
|
Changes requested by @Insti
|
Thanks @rpottsoh ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1008