Skip to content

Conversation

@ErikSchierboom
Copy link
Member

It also adds an "expected" property, that was previously missing but now makes even more sense as the input properties are contained in a separate property.

It also adds an "expected" property, that was previously missing
Copy link
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ErikSchierboom ErikSchierboom merged commit 4de8ef4 into exercism:master Jan 4, 2018
@ErikSchierboom ErikSchierboom deleted the input-meetup branch January 4, 2018 07:43
@m-dango
Copy link
Member

m-dango commented Jan 4, 2018

Was the removal of dayofmonth intentional?

@ErikSchierboom
Copy link
Member Author

@mienaikage Yes it was, as that was only used to determine the expected value, but we know use a date string for that (which matches existing expected values).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants