luhn: Apply new "input" policy #1054
Conversation
exercises/luhn/canonical-data.json
Outdated
| "cases": [ | ||
| { | ||
| "description": "single digit strings can not be valid", | ||
| "property": "valid", | ||
| "input": "1", | ||
| "input": { | ||
| "ccNumber": "1" |
There was a problem hiding this comment.
I assume ccNumber stands for creditCardNumber. If so, why not write it out and use creditCardNumber instead?
There was a problem hiding this comment.
No reason not to other than the description.md also says it could be used for Canadian Social Insurance Numbers. I didn't want the field to be overly long and I couldn't come up with a good, meaningful, name that was generic enough for this first commit.
Yes, ccNumber stands for creditCardNumber.
There was a problem hiding this comment.
Aha, I see. Maybe we should then revert to something plain like "input"?
There was a problem hiding this comment.
"input" inside of "input"? 👎 Technically, I guess, still satisfies #996. How about "aValue"?
There was a problem hiding this comment.
I don't really like the "a" prefix. How about just "value"?
There was a problem hiding this comment.
Sold! Thanks @ErikSchierboom.
Per #996