pascals-triangle: implement error object #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Insti
reviewed
Sep 21, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "exercise": "pascals-triangle", | |||
| "version": "1.3.0", | |||
| "version": "1.4.0", | |||
| "comments": [ | |||
| "Expectations are represented here as an array of arrays.", | |||
| "How you represent this idiomatically in your language is up to you.", | |||
Insti
reviewed
Sep 21, 2018
| @@ -80,7 +80,7 @@ | |||
| "input": { | |||
| "count": -1 | |||
| }, | |||
| "expected": -1 | |||
| "expected": {"error": "count must be positive"} | |||
There was a problem hiding this comment.
Out of scope for this PR, but (opinion) this test should be removed.
There was a problem hiding this comment.
@Insti your meaning that, in your opinion, this case should be removed because it deals with invalid input? I agree with that opinion. If I am understanding you correctly I will leave this as it is. Another PR can be opened to to remove this case.
There was a problem hiding this comment.
@rpottsoh you understand me and I agree with you. 😄
Insti
approved these changes
Sep 24, 2018
per exercism#1311 pascals-triangle: update comment re: errors Per @Insti's suggestion....
rpottsoh
force-pushed
the
updatePascalsTriangle
branch
from
1ab90c5 to
7dd47bd
Compare
rpottsoh
added a commit
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1311