Skip to content

simple-cipher: remove checks for invalid input #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2018
Merged

simple-cipher: remove checks for invalid input #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8c968
simple-cipher: remove mention of invalid input from README
rpottsoh Oct 2, 2018
5eb79cf
simple-cipher: remove invalid input cases
rpottsoh Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 1 addition & 30 deletions exercises/simple-cipher/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "simple-cipher",
"version": "1.1.0",
"version": "1.2.0",
"comments":
["Some of the strings used in this file are symbolic and do not represent their literal value. They are:",
"cipher.key - Represents the Cipher key",
Expand Down Expand Up @@ -114,35 +114,6 @@
"expected": "iboaqcnecbfcr"
}
]
},
{
"description": "Incorrect key cipher",
"cases": [
{
"description": "Throws an error with an all uppercase key",
"property": "new",
"input": {
"key": "ABCDEF"
},
"expected": { "error": "Bad key" }
},
{
"description": "Throws an error with a numeric key",
"property": "new",
"input": {
"key": "12345"
},
"expected": { "error": "Bad key" }
},
{
"description": "Throws an error with empty key",
"property": "new",
"input": {
"key": ""
},
"expected": { "error": "Bad key" }
}
]
}
]
}
5 changes: 1 addition & 4 deletions exercises/simple-cipher/description.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@ substitution cipher a little more fault tolerant by providing a source
of randomness and ensuring that the key contains only lowercase letters.

If someone doesn't submit a key at all, generate a truly random key of
at least 100 characters in length.

If the key submitted is not composed only of lowercase letters, your
solution should handle the error in a language-appropriate way.
at least 100 alphanumeric characters in length.

## Extensions

Expand Down