Skip to content

hamming: remove mention of -1 as error indication #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

rpottsoh
Copy link
Member

@rpottsoh rpottsoh commented Nov 9, 2018

fixes #1385

@rpottsoh rpottsoh requested a review from petertseng November 9, 2018 21:03
@rpottsoh
Copy link
Member Author

rpottsoh commented Nov 9, 2018

@petertseng if you are OK with these changes I would not be offended if you went ahead and merged.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I find there to be only a very low chance that the both of us missed anything. But I'll leave it for a few hours in case someone does see something.

@rpottsoh rpottsoh merged commit 5f71c00 into exercism:master Nov 11, 2018
@rpottsoh rpottsoh deleted the fixHamming branch November 11, 2018 20:50
petertseng added a commit to petertseng/exercism-ceylon that referenced this pull request Nov 14, 2018
petertseng added a commit to petertseng/exercism-ceylon that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hamming: JSON doesn't need to mention -1 anymore
2 participants