Skip to content

Robot simulator descriptions too long #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Robot simulator descriptions too long #1525

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea538f6
Robot simulator descriptions too long
bencoman Jun 5, 2019
12a2ccc
fix missing comma, thx @SleeplessByte
bencoman Jun 5, 2019
99706b8
update per suggestions from SleeplessByte
bencoman Jun 5, 2019
8cf9021
make descriptions a bit more verbose
bencoman Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions exercises/robot-simulator/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "robot-simulator",
"version": "3.1.0",
"version": "3.2.0",
"comments": [
"Some tests have two expectations: one for the position, one for the direction",
"Optionally, you can also test",
Expand All @@ -10,10 +10,10 @@
],
"cases": [
{
"description": "A robot is created with a position and a direction",
"description": "Create robot",
"cases": [
{
"description": "Robots are created with a position and direction",
"description": "at origin facing north",
"property": "create",
"input": {
"position": {
Expand All @@ -31,7 +31,7 @@
}
},
{
"description": "Negative positions are allowed",
"description": "at negative position facing south",
"property": "create",
"input": {
"position": {
Expand All @@ -51,10 +51,10 @@
]
},
{
"description": "rotates the robot's direction 90 degrees clockwise",
"description": "Rotating clockwise",
"cases": [
{
"description": "changes the direction from north to east",
"description": "changes north to east",
"property": "move",
"input": {
"position": {
Expand All @@ -73,7 +73,7 @@
}
},
{
"description": "changes the direction from east to south",
"description": "changes east to south",
"property": "move",
"input": {
"position": {
Expand All @@ -92,7 +92,7 @@
}
},
{
"description": "changes the direction from south to west",
"description": "changes south to west",
"property": "move",
"input": {
"position": {
Expand All @@ -111,7 +111,7 @@
}
},
{
"description": "changes the direction from west to north",
"description": "changes west to north",
"property": "move",
"input": {
"position": {
Expand All @@ -132,10 +132,10 @@
]
},
{
"description": "rotates the robot's direction 90 degrees counter-clockwise",
"description": "Rotating counter-clockwise",
"cases": [
{
"description": "changes the direction from north to west",
"description": "changes north to west",
"property": "move",
"input": {
"position": {
Expand All @@ -154,7 +154,7 @@
}
},
{
"description": "changes the direction from west to south",
"description": "changes west to south",
"property": "move",
"input": {
"position": {
Expand All @@ -173,7 +173,7 @@
}
},
{
"description": "changes the direction from south to east",
"description": "changes south to east",
"property": "move",
"input": {
"position": {
Expand All @@ -192,7 +192,7 @@
}
},
{
"description": "changes the direction from east to north",
"description": "changes east to north",
"property": "move",
"input": {
"position": {
Expand All @@ -213,10 +213,10 @@
]
},
{
"description": "moves the robot forward 1 space in the direction it is pointing",
"description": "Moving forward one",
"cases": [
{
"description": "increases the y coordinate one when facing north",
"description": "facing north increments Y",
"property": "move",
"input": {
"position": {
Expand All @@ -235,7 +235,7 @@
}
},
{
"description": "decreases the y coordinate by one when facing south",
"description": "facing south decrements Y",
"property": "move",
"input": {
"position": {
Expand All @@ -254,7 +254,7 @@
}
},
{
"description": "increases the x coordinate by one when facing east",
"description": "facing east increments X",
"property": "move",
"input": {
"position": {
Expand All @@ -273,7 +273,7 @@
}
},
{
"description": "decreases the x coordinate by one when facing west",
"description": "facing west decrements X",
"property": "move",
"input": {
"position": {
Expand All @@ -294,10 +294,13 @@
]
},
{
"description": "Where R = Turn Right, L = Turn Left and A = Advance, the robot can follow a series of instructions and end up with the correct position and direction",
"description": "Follow series of instructions",
"comments": [ "The robot can follow a series of instructions and end up with the correct position and direction.",
"Where R = Turn Right, L = Turn Left and A = Advance"
],
"cases": [
{
"description": "instructions to move east and north from README",
"description": "moving east and north from README",
"property": "move",
"input": {
"position": {
Expand All @@ -316,7 +319,7 @@
}
},
{
"description": "instructions to move west and north",
"description": "moving west and north",
"property": "move",
"input": {
"position": {
Expand All @@ -335,7 +338,7 @@
}
},
{
"description": "instructions to move west and south",
"description": "moving west and south",
"property": "move",
"input": {
"position": {
Expand All @@ -354,7 +357,7 @@
}
},
{
"description": "instructions to move east and north",
"description": "moving east and north",
"property": "move",
"input": {
"position": {
Expand Down