Skip to content

ETL: input elements define function parameter count #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2019
Merged

ETL: input elements define function parameter count #1536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce1fa1f
ETL: input elements define function parameter count
bencoman Jun 16, 2019
5aceeb8
etl: only one input parameter
bencoman Jun 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions exercises/etl/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "etl",
"version": "1.0.1",
"version": "2.0.0",
"cases": [
{
"comments": [
Expand All @@ -18,7 +18,9 @@
"description": "single letter",
"property": "transform",
"input": {
"1": ["A"]
"legacy": {
"1": ["A"]
}
},
"expected": {
"a": 1
Expand All @@ -28,7 +30,9 @@
"description": "single score with multiple letters",
"property": "transform",
"input": {
"1": ["A", "E", "I", "O", "U"]
"legacy": {
"1": ["A", "E", "I", "O", "U"]
}
},
"expected": {
"a": 1,
Expand All @@ -42,8 +46,10 @@
"description": "multiple scores with multiple letters",
"property": "transform",
"input": {
"1": ["A", "E"],
"2": ["D", "G"]
"legacy": {
"1": ["A", "E"],
"2": ["D", "G"]
}
},
"expected": {
"a": 1,
Expand All @@ -56,13 +62,15 @@
"description": "multiple scores with differing numbers of letters",
"property": "transform",
"input": {
"1": ["A", "E", "I", "O", "U", "L", "N", "R", "S", "T"],
"2": ["D", "G"],
"3": ["B", "C", "M", "P"],
"4": ["F", "H", "V", "W", "Y"],
"5": ["K"],
"8": ["J", "X"],
"10": ["Q", "Z"]
"legacy": {
"1": ["A", "E", "I", "O", "U", "L", "N", "R", "S", "T"],
"2": ["D", "G"],
"3": ["B", "C", "M", "P"],
"4": ["F", "H", "V", "W", "Y"],
"5": ["K"],
"8": ["J", "X"],
"10": ["Q", "Z"]
}
},
"expected": {
"a": 1, "b": 3, "c": 3, "d": 2, "e": 1,
Expand Down