Skip to content

Resistor Color: Additional info for problem spec #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Resistor Color: Additional info for problem spec #1548

wants to merge 2 commits into from

Conversation

okeegan
Copy link

@okeegan okeegan commented Jul 5, 2019

Resolves #1546.

okeegan added 2 commits July 5, 2019 10:06
Added more information about the task requirements.
Resistor color: Update the task description
More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code)
More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code).

Create the means to look up the numerical value associated with a particular color band.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this line between the "Mnemonic" and "More information" lines? I feel like the "More information" line should probably be the last line.

More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code)
More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code).

Create the means to look up the numerical value associated with a particular color band.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the "Create the means" line could be moved above the "More information" link, but then the prescriptive sense of the sentence is a little lost. Perhaps change it to "The goal of this exercise is to create" instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the move idea as well.

More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code)
More information on the color encoding of resistors can be found in the [Electronic color code Wikipedia article](https://en.wikipedia.org/wiki/Electronic_color_code).

Create the means to look up the numerical value associated with a particular color band.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the move idea as well.

@okeegan
Copy link
Author

okeegan commented Jul 22, 2019

I question the usefulness of the wikipedia links in the task description. Surely if someone was interested they're only a google and a click away from that information?

@ErikSchierboom
Copy link
Member

I question the usefulness of the wikipedia links in the task description. Surely if someone was interested they're only a google and a click away from that information?

I'm not sure I understand this argument to be honest. Surely the same reasoning could be applied to any link?

@okeegan
Copy link
Author

okeegan commented Jul 22, 2019

Good point! I was really just thinking that very few other exercises have this kind of link to more information in the body, instead opting to give information about the source of the problem or concept in the 'Source' section.

@ErikSchierboom
Copy link
Member

Well, source should in general link to the page that served as the inspiration for the exercise. That could be a Wikipedia article, although it usually is another page (e.g. an issue in this repository).

@iHiD iHiD closed this Jan 27, 2021
@iHiD iHiD deleted the branch exercism:master January 27, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resistor color: no task description
5 participants