hamming: normalize error messages #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I relased that #1762 does not normalize the error messages, it just makes them the same Additionally, took the opportunity to normalize descriptions to use first strand/second strand, rather than a mix of that and left strand/right strand
wolf99
requested review from
ErikSchierboom,
SleeplessByte,
kotp and
petertseng
kotp
approved these changes
Feb 15, 2021
SleeplessByte
approved these changes
Feb 15, 2021
ErikSchierboom
approved these changes
Feb 16, 2021
Member
|
Thanks @wolf99! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that #1762 does not normalize the error messages, it just makes them the same
Additionally, took the opportunity to normalize descriptions to use first strand/second strand, rather than a mix of that and left strand/right strand