affine-cipher: Updates to the exercise instructions file #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I have tried to clean up the instructions to this exercise a bit and possibly make them a bit more informative by: * Changing the markdown text from plain to `code` for important values to let them stand out * Adding the Encryption and Decryption section headers for improved clarity * Adding guidance about digits and spaces as inputs to match the test cases * Updating the Decryption formula to avoid exponent ambiguity * Updated the MMI property formula to be more consistent with the resource (Wiki), and subjectively easier to grasp * Adding a hint about what coprimes (or relative primes) are for improved clarity * Removing one example of MMI which seemed to be redundant Please review the proposed updates and let me know what you think - they are subjective so it's perfectly fine if only some / none of them will be accepted. Thank you for your time!
|
The update was originally submitted for the F# path but was moved here, based on maintainers request. |
petertseng
changed the title
petertseng
reviewed
Oct 12, 2021
Updates: * Replaced "here" with more descriptive text for clarity * Removed requirement to return error code `1` as it is language dependent * Capitalized Roman
onpikono
commented
Oct 12, 2021
|
I hope I did everything correctly; this is the first time I am doing this kind of "back-and-forth" PR. |
OK. Co-authored-by: Erik Schierboom <[email protected]>
Ok. Thanks! Co-authored-by: Erik Schierboom <[email protected]>
|
Maybe it's just the way it is displayed in my browser; but it seems that although you have continued the existing style in the file of hard line wraps at a specific column count, you have used a different column count to the rest of the file. Alternative may be to convert entire file to the preferred style of no hard wraps with instead a new line for each sentence. |
petertseng
approved these changes
Oct 12, 2021
Co-authored-by: Peter Tseng <[email protected]>
Co-authored-by: Peter Tseng <[email protected]>
petertseng
approved these changes
Oct 12, 2021
ErikSchierboom
approved these changes
Oct 13, 2021
wolf99
approved these changes
Oct 13, 2021
|
Thanks a lot @onpikono! |
Thank you and all the others involved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have tried to clean up the instructions to this exercise a bit and possibly make them a bit more informative by:
codefor important values to let them stand outPlease review the proposed updates and let me know what you think - they are subjective so it's perfectly fine if only some / none of them will be accepted. Thank you for your time!