Merged
Conversation
Contributor
It has that by default, doesn't it? The secret it needs in addition to the defaults is an SSH deploy key so that pushing triggers CI. |
Member
Author
|
Ah, makes sense. |
wolf99
reviewed
Feb 1, 2022
wolf99
reviewed
Feb 1, 2022
.github/workflows/action-format.yml
Outdated
Comment on lines
+85
to
+86
| - name: Verify that canonical-data.json files adhere to their json schema | ||
| run: yarn format-json |
Member
There was a problem hiding this comment.
This doesn't verify. This writes. Right?
Member
Author
There was a problem hiding this comment.
Correct. I've updated.
ErikSchierboom
force-pushed
the
format-action
branch
from
7a067ad to
858a535
Compare
wolf99
approved these changes
Feb 2, 2022
kotp
approved these changes
Feb 6, 2022
SaschaMann
approved these changes
Feb 6, 2022
Member
|
I think I've done it but I don't really have any idea what I'm doing :) |
Contributor
|
@iHiD in that case, could you approve this PR so we can merge it and we'll try it out in a test PR? :) |
iHiD
approved these changes
Feb 8, 2022
ErikSchierboom
added a commit
to ErikSchierboom/problem-specifications
that referenced
this pull request
Feb 11, 2022
* Format using prettier (exercism#1917) Format using prettier * updated description of anagrams exercise (exercism#1928) * updated description of anagrams * changed anagram description to be one-sentence-per-line * updated description of anagrams to use sets * Update Licence Give a look at the discussion in BR exercism#1930 * rational-numbers: test to reduce abs value (exercism#1938) * Change saddle point references to row, column (exercism#1948) * word-search: Add test case * Update exercises/word-search/canonical-data.json Agreed. Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com> * meetup: improve descriptions by saying why each case is tested (exercism#1919) descriptions show whether a date is the first, last, or an arbitrary middle date of the week. This helps understand why certain cases are selected. Closes exercism#974 * word-search: Add cases checking for concatenation and wrapping The author of this commit thinks that concatenation is highly unlikely, but the wrapping might be useful to check in languages that allow negative indices. * `flatten-array` Add additional test cases (exercism#1953) * Add additional test cases to flatten-array * Update exercises/flatten-array/canonical-data.json Co-authored-by: Peter Tseng <petertseng@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Peter Tseng <petertseng@users.noreply.github.com> * Fix bowling game copy (exercism#1955) Fixes exercism#1954 * Add action to format code (exercism#1941) * build(deps): bump DavidAnson/markdownlint-cli2-action (exercism#1952) Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/DavidAnson/markdownlint-cli2-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/DavidAnson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@b3c3b40...744f913) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reduced rational nr. should be in standard form. (exercism#1958) * Reduced rational should be in standard form. The current instructors fail to mention that a reduced rational number should always be rendered in standard form (without any negative value at the denominator). * remove superflous blank lines; fix wording * scale-generator: use flat and sharp symbols (exercism#1942) * Update configlet part in README (exercism#1949) Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com> * phone number: only one problem per test input (exercism#1959) * [Phone Number] Only one problem per test input Because the area code is not allowed to start with 0 or 1, inputs designed to elicit other errors should not use area codes that start with either of those digits. * Respect immutability * Correct field name: s/comment/comments/ * Comments should contain a list. * Allow prettier to improve comments * book-store: reorder keys * darts: reorder keys * grade-school: reorder keys * hamming: reorder keys * high-scores: reorder keys * largest-series-product: reorder keys * list-ops: reorder keys * luhn: reorder keys * triangle: reorder keys * scale-generator: reorder keys * saddle-points: reorder keys * diffie-hellman: reorder keys * collatz-conjecture: reorder keys * anagram: reorder keys * accumulate: reorder keys * Add CI script to check correct order of keys Co-authored-by: Bart Massey <bart.massey@gmail.com> Co-authored-by: y8l <72172663+yusufadell@users.noreply.github.com> Co-authored-by: Ivan Ivanov <mr.mstranger@gmail.com> Co-authored-by: Damian C. Rossney <dcr8898@users.noreply.github.com> Co-authored-by: mariohuq <mariohuq@github.com> Co-authored-by: mariohuq <mario.huq@gmail.com> Co-authored-by: Peter Tseng <petertseng@users.noreply.github.com> Co-authored-by: Peter Tseng <pht24@cornell.edu> Co-authored-by: AH WEI <88667293+kwchang0831@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Cedd Burge <ceddlyburge@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Davide Alberto Molin <davide@davidemolin.com> Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> Co-authored-by: June <12543047+junedev@users.noreply.github.com> Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com> Co-authored-by: Leah Hanson <astrieanna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1917 to be merged
This is almost a carbon copy of the workflow that the JavaScript track uses.
@iHiD This repo now needs access to the SSH deploy key, like the
javascripttrack.