Skip to content

Clarify description of meetup #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Clarify description of meetup #2147

merged 5 commits into from
Nov 18, 2022

Conversation

kytrinyx
Copy link
Member

There has been a lot of confusion around this exercise, especially
for people who don't speak English as their native language.

This attempts to explain very clearly where 'teenth' comes from,
and how it pertains to recurring monthly meetup schedules.

In doing this I have also made an executive decision to not
change the structure of the inputs (see #1069).
This is because I don't believe that adding string parsing to
get the pieces of the general description makes this exercise
more interesting or fun.

In order to keep the exercise focused on just the date munging,
this instead changes the description to match more closely how
the inputs are given.

Closes #1786.
Closes #1069.

There has been a lot of confusion around this exercise, especially
for people who don't speak English as their native language.

This attempts to explain very clearly where 'teenth' comes from,
and how it pertains to recurring monthly meetup schedules.

In doing this I have also made an executive decision to _not_
change the structure of the inputs (see #1069).
This is because I don't believe that adding string parsing to
get the pieces of the general description makes this exercise
more interesting or fun.

In order to keep the exercise focused on just the date munging,
this instead changes the description to match more closely how
the inputs are given.

Closes #1786.
Closes #1069.
@kytrinyx kytrinyx force-pushed the meetup-clarification branch from ab93c97 to be3d2fe Compare November 10, 2022 19:04
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work!

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. As a non-native speaker I remember struggling with this exercise in the past.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@jiegillet jiegillet merged commit 09f4760 into main Nov 18, 2022
@jiegillet jiegillet deleted the meetup-clarification branch November 18, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meetup, what does "-teenth" mean? meetup: description.md doesn't match up with canonical-data
4 participants