-
-
Notifications
You must be signed in to change notification settings - Fork 556
Clarify description of meetup #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bded7bd
to
ab93c97
Compare
There has been a lot of confusion around this exercise, especially for people who don't speak English as their native language. This attempts to explain very clearly where 'teenth' comes from, and how it pertains to recurring monthly meetup schedules. In doing this I have also made an executive decision to _not_ change the structure of the inputs (see #1069). This is because I don't believe that adding string parsing to get the pieces of the general description makes this exercise more interesting or fun. In order to keep the exercise focused on just the date munging, this instead changes the description to match more closely how the inputs are given. Closes #1786. Closes #1069.
ab93c97
to
be3d2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work!
Co-authored-by: Erik Schierboom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. As a non-native speaker I remember struggling with this exercise in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
There has been a lot of confusion around this exercise, especially
for people who don't speak English as their native language.
This attempts to explain very clearly where 'teenth' comes from,
and how it pertains to recurring monthly meetup schedules.
In doing this I have also made an executive decision to not
change the structure of the inputs (see #1069).
This is because I don't believe that adding string parsing to
get the pieces of the general description makes this exercise
more interesting or fun.
In order to keep the exercise focused on just the date munging,
this instead changes the description to match more closely how
the inputs are given.
Closes #1786.
Closes #1069.