Skip to content

saddle-points: instructions: fix directions#2264

Merged
kytrinyx merged 1 commit into
exercism:mainfrom
ee7:saddle-points-instructions-directions
Apr 12, 2023
Merged

saddle-points: instructions: fix directions#2264
kytrinyx merged 1 commit into
exercism:mainfrom
ee7:saddle-points-instructions-directions

Conversation

@ee7

@ee7 ee7 commented Apr 11, 2023

Copy link
Copy Markdown
Member

Please double-check that I haven't become confused here.

This PR is a follow-up of #2248 (comment).


These directions didn't match what we said elsewhere in the instructions:

An acceptable tree will be the largest in its row, while being the smallest in its column.

And in the introduction:

The best tree will be the tallest tree compared to all the other trees to the east and west, so that you have the best possible view of the sunrises and sunsets.

You don't like climbing too much, so the perfect tree will also be the shortest among all the trees to the north and to the south.

And in the test cases:

Here is a grid that has exactly one candidate tree.

    1  2  3  4
  |-----------
1 | 9  8  7  8
2 | 5  3  2  4  <--- potential tree house at row 2, column 1, for tree with height 5
3 | 6  6  7  1
  • Row 2 has values 5, 3, and 1. The largest value is 5.
  • Column 1 has values 9, 5, and 6. The smallest value is 5.

So the point at [2, 1] (row: 2, column: 1) is a great spot for a tree house.

Fixes: #2263

These directions didn't match what we said elsewhere in the
instructions:

    An acceptable tree will be the largest in its row, while being the
    smallest in its column.

And in the introduction:

    The best tree will be the tallest tree compared to all the other
    trees to the east and west, so that you have the best possible view
    of the sunrises and sunsets.

    You don't like climbing too much, so the perfect tree will also be
    the shortest among all the trees to the north and to the south.

And in the test cases:

    Here is a grid that has exactly one candidate tree.

        1  2  3  4
      |-----------
    1 | 9  8  7  8
    2 | 5  3  2  4  <--- potential tree house at row 2, column 1, for tree with height 5
    3 | 6  6  7  1

    - Row 2 has values 5, 3, and 1. The largest value is 5.
    - Column 1 has values 9, 5, and 6. The smallest value is 5.

    So the point at `[2, 1]` (row: 2, column: 1) is a great spot for a tree house.

Fixes: exercism#2263
@ee7
ee7 requested a review from a team as a code owner April 11, 2023 12:24
@ee7
ee7 requested a review from kytrinyx April 11, 2023 12:27
@IsaacG

IsaacG commented Apr 11, 2023

Copy link
Copy Markdown
Member

The grid isn't oriented with North at the top. This was previously called out and is being discussed but the exercise is internally consistent.

@ee7
ee7 requested a review from IsaacG April 11, 2023 12:48

@kytrinyx kytrinyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check that I haven't become confused here.

😂 I feel like this is the story of my life!

@kytrinyx
kytrinyx merged commit ec60b85 into exercism:main Apr 12, 2023
@ee7
ee7 deleted the saddle-points-instructions-directions branch April 12, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

saddle-points: directions seem mixed up

4 participants