Grains: Add canonical-data.json file #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementations of this exercise are all nearly identical, so creating a canonical test set was just a matter of documenting the existing tests. Some languages do not include the error-handling tests, but I think they are valuable to include as the boundaries they test are part of the problem domain.
Insti
reviewed
Oct 22, 2016
| "description": "square greater than 64 raises an execption", | ||
| "input": 65, | ||
| "expected": -1 | ||
| }, |
There was a problem hiding this comment.
This trailing comma is causing the linter to complain.
IanWhitney
pushed a commit
to IanWhitney/xrust
that referenced
this pull request
Oct 22, 2016
Follows the standard test suite, which is currently waiting for merge. exercism/problem-specifications#420 I did not include the test of square -1 since that would require the function signature to be `i32`. Placement is at the end of the "Introduction" section. It introduces a couple of concepts that may be new, - declaring number types - panic & should_panic I thought it would be nice to get some exposure to `panic` before introducing `result` in the Hamming exercise.
kytrinyx
approved these changes
Oct 23, 2016
IanWhitney
added a commit
to exercism/rust
that referenced
this pull request
Oct 25, 2016
* Implement grains Follows the standard test suite, which is currently waiting for merge. exercism/problem-specifications#420 I did not include the test of square -1 since that would require the function signature to be `i32`. Placement is at the end of the "Introduction" section. It introduces a couple of concepts that may be new, - declaring number types - panic & should_panic I thought it would be nice to get some exposure to `panic` before introducing `result` in the Hamming exercise. Re: stub src/lib.rs file This is pretty early in the track, so signatures can be handy. And not getting a bunch of compilation errors is also nice. I don't think that this stub forces any particular implementation, though the setting of type of `s` to `u32` does help the students over a bit of type-casting hassle.
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementations of this exercise are all nearly identical, so
creating a canonical test set was just a matter of documenting the
existing tests.
Some languages do not include the error-handling tests, but I think they
are valuable to include as the boundaries they test are part of the
problem domain.