Add descriptions for the raindrops tests. #450
Conversation
| "number" : 10, | ||
| "expected": "Plang" | ||
| }, | ||
| { | ||
| "description" : "the sound for 14 is Plong", |
There was a problem hiding this comment.
I rather like the cases for 9, and 10, where there is an explanation for the sound in the description. It is missing here, is this by design?
There was a problem hiding this comment.
No, it's just a mistake. I'll correct it when I get back to my pc.
There was a problem hiding this comment.
I updated the description for 14.
| "number" : 6, | ||
| "expected": "Pling" | ||
| }, | ||
| { | ||
| "description" : "the sound for 8 is 8", |
There was a problem hiding this comment.
Does it make sense to include the reasoning for #370 in here? In particular, that 2^3 is not "Pling" since the 3 is the power, rather than the base?
There was a problem hiding this comment.
If it's a common mistake in implemention is this exercise, then why not.
Something like "2 to the power 3 does not make a raindrop sound as 3 is the power not the base"?
There was a problem hiding this comment.
That proposed description seems good.
Caveat on the strength of my opinion: Whether it qualifies for common isn't known first-hand to me as I haven't done this exercise in any language. A particular way of doing it in Ruby (exercism/ruby#434) first caused this case to be added.
But I figure... now that it's added, might as well give it the description to suit it, and I think this description does suit.
There was a problem hiding this comment.
I updated the description for 8.
Add better explanations for 8 and 14.
|
Changes look good to me |
Added in exercism/problem-specifications#370 Although I doubt anyone will make the same mistake in this language, I don't care enough to declare that we should elide these cases. Note that even though Rust now has the same cases as 1.0.0, we don't have descriptions like in exercism/problem-specifications#450. I don't find them terribly necessary, but I suppose they can be added if they seem good. We would likely no longer be able to have the tests on one line in that case, since some descriptions are rather long.
Add test for 10 card; add test comparing 5-high straight to other str…
Unlike the other canonical-data I have seen, the tests have no description.
I'm writing a test generator for the xocaml stream - it fails due to this.