Skip to content

RFC: hello-world: remove reference to "name not given" #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions exercises/hello-world/canonical-data.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,14 @@
{
"#": [
"Language implementations vary on the issue of missing input variables.",
"In this set of test cases, the input variable is left out of the definition,",
"and the generator would need to handle the language implementation."
],
"cases": [
{
"description": "no name",
"expected": "Hello, World!"
},
{
"description": "sample name",
"name": "Alice",
"expected": "Hello, Alice!"
},
{
"description": "other sample name",
"name": "Bob",
"expected": "Hello, Bob!"
"name": "World",
"expected": "Hello, World!"
}
]
}
6 changes: 2 additions & 4 deletions exercises/hello-world/description.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ the traditional first program for beginning programming in a new language.

## Specification

Write a `Hello World!` function that can greet someone given their name. The
function should return the appropriate greeting.
Write a `Hello World!` function that can greet the world or a specific person.
The function should return the appropriate greeting.

For an input of "Alice", the response should be "Hello, Alice!".

If a name is not given, the response should be "Hello, World!"

## Test-Driven Development

As programmers mature, they eventually want to test their code.
Expand Down