-
-
Notifications
You must be signed in to change notification settings - Fork 555
allergies: Make exercise schema-compliant #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"cases": [ | ||
{ | ||
"description": "allergicTo", | ||
"comments": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I misreading the spec, or doesn't comments
go at the top level?
"canonicalData":
{ "description": "This is the top-level file structure"
, "type" : "object"
, "required" : ["exercise" , "version", "cases"]
, "properties" :
{ "exercise" : { "$ref": "#/definitions/exercise" }
, "version" : { "$ref": "#/definitions/version" }
, "comments" : { "$ref": "#/definitions/comments" }
, "cases" : { "$ref": "#/definitions/testGroup" }
}
, "additionalProperties": false
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have comments in the top level, in a test group, or inside a test, so that people can keep them where they fit better. In this case, it is in the test group because it pertains just that group of test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thanks
@rbasso is this diving into the "more than just formatting and compliance"? |
At first glance it appears it is grouping expectations in a different way. I will look closer though. |
I was forced to move the |
That now makes sense. |
Related to #625.