Skip to content

Beer-Song: Compliance with JSON Schema #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kotp
Copy link
Member

@kotp kotp commented Mar 9, 2017

Adjusts #661 for #625

@kotp kotp changed the title Beer-Song: Compliance with JSON Schema WIP: Beer-Song: Compliance with JSON Schema Mar 9, 2017
@kotp kotp force-pushed the beer-song_Compliance_With_JSON_Schema branch from a7eb5c1 to e566416 Compare March 9, 2017 08:18
@kotp kotp changed the title WIP: Beer-Song: Compliance with JSON Schema Beer-Song: Compliance with JSON Schema Mar 9, 2017
@kotp
Copy link
Member Author

kotp commented Mar 9, 2017

@kytrinyx If this looks good to you, could you merge it into your PR #661

"cases": [
{
"description": "verse",
"cases": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "cases" => "cases" nesting done on purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait. Yeah, I get it.

@kytrinyx kytrinyx merged commit 6ffaf1a into canonical-beer-song Mar 9, 2017
@kytrinyx kytrinyx deleted the beer-song_Compliance_With_JSON_Schema branch March 9, 2017 19:06
@kytrinyx
Copy link
Member

kytrinyx commented Mar 9, 2017

Thanks, @kotp! I remember seeing the schema discussion go by, but haven't paid close attention. This is very helpful.

emcoding pushed a commit that referenced this pull request Nov 19, 2018
Update Generated Test Suites section in README with gem documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants