Make isogram exercise JSON Schema compliant #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
force-pushed
the
isogram-json-schema
branch
from
5f69b04 to
f815088
Compare
rbasso
approved these changes
Mar 10, 2017
There was a problem hiding this comment.
You changed some things:
- Nesting: You added a test group with a new description.
- Comments: You added two comments.
- Compliance: You added
exercise,versionandproperty. - Formatting: Everything was formatted accordingly.
The first two things do not really fit in the commit's title, but they seems to be ok.
The choice of property's name was great! 👍
The forth one could also be a separated commit. This would make a better history and also make reviewing a little easier.
ps: I didn't checked if the test's contents match the original.
75 tasks
|
@rbasso Do you mean I should split the nesting and comments part from compliance? |
|
You don't have to. This is ready to be merged. 👍 It was just a recommendation for future PRs, to consider splitting different things in different commits/PRs. |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Remove instructions for direct test execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #625