tournament: Make exercise schema-compliant #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object 'invalid_lines' with examples of lines that, if inserted in otherwise-valid games would not affect the output, cannot comply with the new JSON schema, so it is being removed. A new test case with invalid lines based on that object is added.
The version is starting at '1.1.0' because we just added a new test case with invalid input lines. This way we can signal that the test suite changed while being converted to the new schema.
This was referenced Mar 12, 2017
petertseng
approved these changes
Mar 12, 2017
There was a problem hiding this comment.
oh, I was thinking one case per invalid line, so that if the test fails the student knows better which line the solution is incorrectly accepting. but all in one case doesn't matter if the behaviour is to ignore.
when invalid lines should reslut in errors, then it makes sense to test each separately
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Wrote some documentation explaining how to regenerate test data and other data for exercises. I also included some changes to explain when to use `-u` to update the VERSION number as well. Lastly, I added a section to the *Contributing* section that gives some ideas for getting started to newcomers, including the newly revamped *Regenerating Test Suites* section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #625.