Skip to content

Probot Stale default configuration #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Probot Stale default configuration #753

wants to merge 1 commit into from

Conversation

kotp
Copy link
Member

@kotp kotp commented Apr 11, 2017

closes: #746
Adds "good first patch" as an exception to stale determination, as
discussed here.

closes: #746
Adds "good first patch" as an exception to stale determination, as
discussed [here][].

[here]: #746 (comment)
@kotp kotp force-pushed the ProbotStaleConfig branch from fd95561 to 25cfd2a Compare April 14, 2017 01:50
@stkent
Copy link
Contributor

stkent commented Apr 17, 2017

Just a question that came to mind: here you've redefined all defaults as well as the customization regarding labels. Is that a recommended strategy? (For reference, in xjava, we only overrode specific parts of the configuration; I'm not sure whether it's better to adopt defaults where possible, or to be more robust and over-specify). 🤔

@kotp
Copy link
Member Author

kotp commented Apr 17, 2017

As per #746 this repository will not use the Probot.


@stkent I changed the values based on discussion in the mentioned discussion, but did copy and paste the entirety as reference in case more was to be changed. I think having the complete set of options that exist being in the file is helpful for quick modification. I simply did not know if further discussion would have me make changes and wanted the information close.

@kotp kotp closed this Apr 17, 2017
@kotp kotp deleted the ProbotStaleConfig branch April 17, 2017 13:58
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Seems appropriate to link to the below section on disabling all skips, but I couldn't find examples of that happening elsewhere. Also not sure if tying the link in to github's style of id generation is desirable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override probot/stale defaults, if necessary
2 participants