meetup: grouping testcase and update descriptions #978
Conversation
|
Thanks for taking this on ❤️ |
Insti
changed the title
| "dayofweek": "Sunday", | ||
| "dayofmonth": 14 | ||
| }, | ||
| "description": "test -teenth", |
There was a problem hiding this comment.
Grouping the tests this way is good 👍
It may not end up in the final version but it is a good way to see which tests exist and what the logical groupings are.
| "description": "monteenth", | ||
| "cases": [ | ||
| { | ||
| "description": "testcase 1 : May 2013", |
There was a problem hiding this comment.
testcase 1 : May 2013
What is this describing?
That it is "testcase 1" can be determined by the array ordering, so is unnecessary in the description.
Why are we testing May and not June? Why are we testing 2013 and not 2014?
| "dayofmonth": 19 | ||
| }, | ||
| { | ||
| "description": "testcase 3 : September 2013", |
There was a problem hiding this comment.
Why are there 3 tests?
What is different about them?
Why have we not tested June and July?
| "month": 5, | ||
| "week": "first", | ||
| "dayofweek": "Tuesday", | ||
| "dayofmonth": 7 |
There was a problem hiding this comment.
It can be constructed, but none of these values match the input format in the description:
the first Monday of January 2017
It may be that the cases should look something like:
"description": "First Monday of a month that starts on Sunday",
"property": "date",
"input": "First Monday of January 2017",
"expected": { "year": 2017, "month": 1, "day": 2 }
|
Thanks @jiippoozz this is a great start. The TDD process should be able to guide us toward a minimal set of tests that demonstrate all the required functionality. Have you already implemented this exercise yourself? |
|
I've submitted a PR (#982) to help clarify the description for this problem, this might effect which test cases are needed and their formatting. |
|
Are you still working on this @jiippoozz ? Do you need any help? |
|
@jiippoozz Small bump. Are you still working on this? If so, you should probably rebase this PR on the latest master, as there has been a small change to the structure of the test cases. |
|
The last work that was done on this PR was over two months ago and there has not been any response to my request for information in the comment above. Hence I think we can probably close this PR. Any objections? |
|
I'm gonna close this due to inactivity. If you (@jiippoozz) would at some point return to working on this, you're very much welcome. |
This PR closes #974 by grouping related test cases together and updating descriptions to be more helpful.
I haven't yet finished all test cases. I open the PR to you first for some feedback (if any).