Skip to content

react: update tests to v1.1.0 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmccandless opened this issue Feb 13, 2018 · 2 comments
Closed

react: update tests to v1.1.0 #1257

cmccandless opened this issue Feb 13, 2018 · 2 comments

Comments

@cmccandless
Copy link
Contributor

Canonical Data
@mrcfps mrcfps mentioned this issue Feb 14, 2018
Closed
77 tasks
@mrcfps
Copy link

mrcfps commented Feb 19, 2018

@cmccandless Currently this exercise is implemented in a way quite different from Canonical Data. Should we comply with canonical implementation?

@cmccandless
Copy link
Contributor Author

@mrcfps The canonical data for this exercise did not exist when I implemented the exercise in this track, so I based the tests off of the C# track. Now that there is canonical data, I would prefer to follow that.

@mrcfps mrcfps mentioned this issue Feb 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmccandless @mrcfps