high-scores: incorrect solution can pass the tests

[ali1234]

Consider the following partial solution to this problem:

class HighScores(object):
    def __init__(self, scores):
        self.scores = scores

    def latest(self):
        return self.scores[-1]

    def personal_best(self):
        self.scores.sort()
        return self.scores[-1]

This will pass the tests for the functions it implements. However, if latest is called after calling personal_best, it can give the wrong answer. The current tests do not check for this situation.

[cmccandless]

This issue has come up before in #1735.

Currently, side effect testing is outside the scope of this exercise. There is a discussion here to include such tests, but I would like to wait and see the consensus there before adding these tests here.

Another solution discussed in #1744 would be to convert this track's implementation to use stand-alone functions rather than a class instance, which might make things more clear to students anyway.

[simmol]

PR #1764 will be merged soon that will make the exercise simpler (using separate functions).

[stale]

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.