Skip to content

phone-number: add parameters to exercise placeholder #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilya-khadykin opened this issue Oct 3, 2017 · 8 comments · Fixed by #591
Closed

phone-number: add parameters to exercise placeholder #608

ilya-khadykin opened this issue Oct 3, 2017 · 8 comments · Fixed by #591

Comments

@ilya-khadykin
Copy link
Contributor

We would like you to help us add expected parameters in placeholder templates as described in #509 to make it easier for learners to start working on the exercise in question.

Feel free to ask any questions, we'll be glad to help!
@saurabhchalke
Copy link
Contributor

I would like to contribute to this one.

@saurabhchalke saurabhchalke mentioned this issue Oct 3, 2017
Closed
@saurabhchalke
Copy link
Contributor

saurabhchalke commented Oct 3, 2017 •
edited
Loading

I have closed the previous PR and separated the changes into 2 individual PR.

@saurabhchalke saurabhchalke mentioned this issue Oct 3, 2017
Closed
@saurabhchalke
Copy link
Contributor

Issue fixed in #687

@Sukhj1nder Sukhj1nder mentioned this issue Oct 4, 2017
Merged
@ilya-khadykin
Copy link
Contributor Author

there are two PRs for the same issue: #591 and #687
@Sukhj1nder created his PR first, so it would be fair to merge it.

@saurabhchalke, don't be discouraged, there will be enough issues in this repo thought the month

@Sukhj1nder
Copy link
Contributor

@m-a-ge Is there any issue with the commit, or is it all good to merge?

@ilya-khadykin
Copy link
Contributor Author

I want to hear @saurabhchalke`s opinion and we will figure something out

@Sukhj1nder
Copy link
Contributor

cool, sounds good. :)

@saurabhchalke
Copy link
Contributor

Alright, no problem. I'll look for some other issue in the repo. @m-a-ge

ilya-khadykin added a commit that referenced this issue Oct 4, 2017
@ilya-khadykin
Merge pull request #591 from Sukhj1nder/patch-4
37121de 
phone-number: add parameters to exercise placeholder per #608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Phone Number - added parameters to placeholders
3 participants
@ilya-khadykin @saurabhchalke @Sukhj1nder