-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
perfect-numbers: add topics #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, I am in a little dilemma. I committed topics for Luhn and made a PR, now I added topics for current #848 issue too and made commit. Should I make one more PR ? It will be very generous of you, if you could aid me regarding the same. |
@VibhuKesar the problem is that you used your Feel free to ask questions |
Thanks, I understood. So, I should create both PRs again and push it to a different branch rather than master? |
#949 I make another, I hope I did correct this time. Thanks |
@VibhuKesar no, not really. You should create two separate Pull Requests from two different branches which in turn should contain respective commit |
@VibhuKesar could you create the PR for this one? |
@m-a-ge #961 |
As stated in #808 we need to add topics for exercises. They should be relevant to the exercise even though you might be able to solve it without encountering that topic. Here is the list of commonly used topics in every track - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt, please use topics from this list or add one if you think it's missing but required.
Hint: you can take a look at an example implementation here (SPOILERS) or in a different language.
There are some exercises which have topics in
config.json
, so you can look at them as an example.If you still have questions, I encourage you to ask them before starting working on the issue.
I also suggest claiming the issue by creating an empty PR as discribded here
Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier, so please reference the issue in your PR accordingly.
The text was updated successfully, but these errors were encountered: