Skip to content

perfect-numbers: add topics #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilya-khadykin opened this issue Oct 14, 2017 · 7 comments
Closed

perfect-numbers: add topics #848

ilya-khadykin opened this issue Oct 14, 2017 · 7 comments

Comments

@ilya-khadykin
Copy link
Contributor

As stated in #808 we need to add topics for exercises. They should be relevant to the exercise even though you might be able to solve it without encountering that topic. Here is the list of commonly used topics in every track - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt, please use topics from this list or add one if you think it's missing but required.
Hint: you can take a look at an example implementation here (SPOILERS) or in a different language.

There are some exercises which have topics in config.json, so you can look at them as an example.

If you still have questions, I encourage you to ask them before starting working on the issue.

I also suggest claiming the issue by creating an empty PR as discribded here

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier, so please reference the issue in your PR accordingly.

@VibhuKesar
Copy link
Contributor

Hello, I am in a little dilemma. I committed topics for Luhn and made a PR, now I added topics for current #848 issue too and made commit. Should I make one more PR ? It will be very generous of you, if you could aid me regarding the same.
Thanks

@ilya-khadykin
Copy link
Contributor Author

ilya-khadykin commented Oct 16, 2017

@VibhuKesar the problem is that you used your master branch for creating both PRs.
Anything you push to that branch (master in your case) will appear in both PRs automatically. For that reason it's always a good idea to use different branches for creating PRs, it's a main idea in git, always use them.
Plus, master branch has a special meaning and it isn't recommended to work directly in it (there some exceptions of course).
Does it makes sense?

Feel free to ask questions

@VibhuKesar
Copy link
Contributor

Thanks, I understood. So, I should create both PRs again and push it to a different branch rather than master?

@VibhuKesar
Copy link
Contributor

#949 I make another, I hope I did correct this time. Thanks

@ilya-khadykin
Copy link
Contributor Author

@VibhuKesar no, not really.
There are two commits for different exercises in your PR - https://github.com/exercism/python/pull/949/commits

You should create two separate Pull Requests from two different branches which in turn should contain respective commit

@ilya-khadykin
Copy link
Contributor Author

@VibhuKesar could you create the PR for this one?

@VibhuKesar
Copy link
Contributor

@m-a-ge #961
I have made the PR for perfect numbers. I hope this is fine. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants