Skip to content

binary-search: Add test version string #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 27, 2017
Merged

Conversation

CSJedi
Copy link

@CSJedi CSJedi commented Oct 25, 2017

Hi, I checked data in binary_search_test.py with data in canonical-data.json

resolves #989

@@ -2,6 +2,7 @@

from binary_search import binary_search

# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the version number is wrong - the canonical data is version 1.0.0.

This like also need to have an extra blank line before it in order to pass the flake8 tests for compliance with PEP8.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so if I change nuber of version , all will pass good?

@N-Parsons
Copy link
Contributor

Hi @CSJedi, could you include resolves #989 in the PR description? Magic words help us to keep track of issues.

It would also be helpful in future PRs to have the exercise name at the start of the PR title - it makes it easier for maintainers to see at a glance.

@CSJedi CSJedi changed the title check data in binary_search_test.py and current version of the canoni… resolves #989 check data in binary_search_test.py and current version of the canoni… Oct 26, 2017
@CSJedi
Copy link
Author

CSJedi commented Oct 26, 2017

I added resolves #989 to description of this issue. Did I do this right? You mean that on "resolves #989"

@CSJedi
Copy link
Author

CSJedi commented Oct 26, 2017

Do you need help in checking another files?

@CSJedi
Copy link
Author

CSJedi commented Oct 26, 2017

Do I do this check right?

@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test.py and current version of the canoni… resolves #989 check data in binary_search_test #hacktober Oct 26, 2017
@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test #hacktober resolves #989 check data in binary_search_test #hacktoberfest Oct 26, 2017
@CSJedi CSJedi closed this Oct 26, 2017
@CSJedi CSJedi reopened this Oct 26, 2017
@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test #hacktoberfest resolves #989 check data in binary_search_test [proposed Label] hacktoberfest Oct 26, 2017
@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test [proposed Label] hacktoberfest resolves #989 check data in binary_search_test [Label] hacktoberfest Oct 26, 2017
@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test [Label] hacktoberfest resolves #989 check data in binary_search_test [[proposed Label]] hacktoberfest Oct 26, 2017
@CSJedi CSJedi changed the title resolves #989 check data in binary_search_test [[proposed Label]] hacktoberfest resolves #989 check data in binary_search_test [proposed Label] hacktoberfest Oct 26, 2017
@CSJedi CSJedi closed this Oct 26, 2017
@CSJedi CSJedi reopened this Oct 26, 2017
@ilya-khadykin
Copy link
Contributor

@CSJedi what's the deal with all of this renaming stuff?

@cmccandless
Copy link
Contributor

@CSJedi The hacktoberfest label is not required for Hacktoberfest credit.

@N-Parsons N-Parsons changed the title resolves #989 check data in binary_search_test [proposed Label] hacktoberfest binary-search: Add test version string Oct 27, 2017
@N-Parsons
Copy link
Contributor

Hi @CSJedi, thanks for fixing the version number. Looks like everything is good now, so I'll merge it.

I've updated the description and title of your PR for you, to show you what I meant. Using this format for the title helps us to easily see what the PR does, and the magic words in the description (appears as your first comment here) mean that the corresponding issue will automatically be closed when the PR is merged.

@N-Parsons N-Parsons merged commit 636909b into exercism:master Oct 27, 2017
josix pushed a commit to josix/python that referenced this pull request Oct 28, 2017
* Add test version string (tests already up-to-date)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binary-search: check test version and update if necessary
4 participants