-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
binary-search: Add test version string #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -2,6 +2,7 @@ | |||
|
|||
from binary_search import binary_search | |||
|
|||
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the version number is wrong - the canonical data is version 1.0.0
.
This like also need to have an extra blank line before it in order to pass the flake8
tests for compliance with PEP8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, so if I change nuber of version , all will pass good?
Hi @CSJedi, could you include It would also be helpful in future PRs to have the exercise name at the start of the PR title - it makes it easier for maintainers to see at a glance. |
Do you need help in checking another files? |
Do I do this check right? |
@CSJedi what's the deal with all of this renaming stuff? |
@CSJedi The |
Hi @CSJedi, thanks for fixing the version number. Looks like everything is good now, so I'll merge it. I've updated the description and title of your PR for you, to show you what I meant. Using this format for the title helps us to easily see what the PR does, and the magic words in the description (appears as your first comment here) mean that the corresponding issue will automatically be closed when the PR is merged. |
* Add test version string (tests already up-to-date)
Hi, I checked data in binary_search_test.py with data in canonical-data.json
resolves #989