Skip to content

rna-transcription: update tests to version 1.0.1 #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 26, 2017
Merged

rna-transcription: update tests to version 1.0.1 #1035

merged 7 commits into from
Oct 26, 2017

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Oct 25, 2017 •
edited
Loading

Resolves #1020

@ilya-khadykin
Copy link
Contributor

ilya-khadykin commented Oct 25, 2017 •
edited
Loading

Build failed due to code style issues:

3.98s$ flake8
./exercises/rna-transcription/rna_transcription_test.py:11:1: W293 blank line contains whitespace
./exercises/rna-transcription/rna_transcription_test.py:13:43: W291 trailing whitespace
The command "flake8" failed and exited with 1 during .
Your build has been stopped.

ilya-khadykin
ilya-khadykin suggested changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve code style issues

@cmccandless cmccandless mentioned this pull request Oct 25, 2017
Closed
@cmccandless
Copy link
Contributor

To quote @N-Parsons in #1030:

Please use a meaningful title for the PR that includes the exercise name - it makes it much easier to handle pull requests. I would suggest using all-your-base: Update test order and version string". Could you also please add the magic words resolves #1014 to your PR description so that merging list PR closes the corresponding issue.

In your case, the corresponding issue is #1020

@kishan3 kishan3 changed the title Reordered Tests rna-transcription: update tests to version 1.0.1 Oct 26, 2017
@kishan3
Copy link
Author

kishan3 commented Oct 26, 2017

Fixed styling issues.

cmccandless
cmccandless approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilya-khadykin ilya-khadykin merged commit 1fb4842 into exercism:master Oct 26, 2017
@ilya-khadykin
Copy link
Contributor

Thanks, @kishan3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin approved these changes

@cmccandless cmccandless cmccandless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishan3 @ilya-khadykin @cmccandless