pangram tests updated to 1.3 #1039
Conversation
|
@luoken could you please rename your PR to something more meaningful and add a link to the issue in the description |
|
link to issue : #1018 |
changed to default tests for pig latin
exercises/pangram/pangram_test.py
Outdated
|
|
||
| def test_another_missing_character_x(self): | ||
| self.assertIs( | ||
| is_pangram('the quick brown fish jumps over the lazy dog'), | ||
| False) |
There was a problem hiding this comment.
I don't think that this additional test really adds any coverage?
exercises/pangram/pangram_test.py
Outdated
| @@ -42,14 +43,20 @@ def test_missing_letters_replaced_by_numbers(self): | |||
|
|
|||
| def test_pangram_with_mixedcase_and_punctuation(self): | |||
| self.assertIs( | |||
| is_pangram('"Five quacking Zephyrs jolt my wax bed."'), | |||
| is_pangram('\"Five quacking Zephyrs jolt my wax bed.\"'), | |||
There was a problem hiding this comment.
The \" construct is for escaping the quote in the json - I don't think that they are needed here.
exercises/pangram/pangram_test.py
Outdated
| @@ -2,13 +2,16 @@ | |||
|
|
|||
| from pangram import is_pangram | |||
|
|
|||
|
|
|||
| # test cases adapted from `x-common//canonical-data.json` @ version: 1.0.0 | |||
| # test cases adapted from `x-common//canonical-data.json` @ version: 1.3.0 | |||
There was a problem hiding this comment.
This should reference problem-specifications, ie:
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.3.0
|
@luoken, this PR is currently failing Travis-CI check due to |
|
This issue has been automatically marked as |
|
@N-Parsons As this PR abandoned, but nearly finished, I went ahead and made the requested change. If there is nothing else, go ahead and merge. |
|
This issue has been automatically marked as |
updated to version 1.3 and moved one test to the bottom
Resolves #1018