circular-buffer: Update the tests following the canonical data #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Parsons
reviewed
Oct 26, 2017
| @@ -7,40 +7,37 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.1 | |||
There was a problem hiding this comment.
Minor formatting point, but can you add a blank line after the version string for consistency?
N-Parsons
reviewed
Oct 26, 2017
| def test_read_just_written_item(self): | ||
| buf = CircularBuffer(1) | ||
| buf.write('1') | ||
| self.assertEqual('1', buf.read()) |
There was a problem hiding this comment.
By convention, we use assertEqual(actual, expected) for our tests - can you switch the argument order in all of these tests?
You can check the rest of our conventions in the main README.md.
There was a problem hiding this comment.
Changed then. Thanks to point it out
N-Parsons
reviewed
Oct 26, 2017
| buf.write('3') | ||
| self.assertEqual(buf.read(), '2') | ||
| with self.assertRaises(BufferFullException): | ||
| buf.write('2') | ||
|
|
||
| def test_alternate_write_and_read(self): | ||
| buf = CircularBuffer(2) |
There was a problem hiding this comment.
Looks like this test has been changed in the canonical data - it should be a CircularBuffer(1).
There was a problem hiding this comment.
Changed that. Thanks
N-Parsons
suggested changes
Oct 26, 2017
|
@N-Parsons can you check again? Thanks |
N-Parsons
approved these changes
Oct 27, 2017
|
Looks good. Thanks, @elyssonmr! |
josix
pushed a commit
to josix/python
that referenced
this pull request
Oct 28, 2017
…ism#1047) * circular-buffer: Update the tests following the canonical data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tests following the
canonical datafrom issue #991