word-search: Update tests to version 1.1.0(#1012) #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Oct 26, 2017
| @@ -36,48 +137,179 @@ def test_vertical_words_top_to_bottom(self): | |||
| self.example.search('ecmascript'), | |||
| (Point(9, 0), Point(9, 9)) | |||
| ) | |||
| self.assertEqual( | |||
There was a problem hiding this comment.
There are a lot of redundant and misplaced assertions. Please check that each assertion actually belongs under its test method (Example: checks for "clojure" in self.example should only appear in tests for horizontal words).
- Delete assertions that appearing in multiple test methods - Make sure each test case appearing in correct test methods
…thon into update/word-search
|
@cmccandless I've fixed it, please check if there is any problem. Thanks! |
cmccandless
approved these changes
Oct 26, 2017
N-Parsons
reviewed
Oct 26, 2017
| @@ -2,9 +2,112 @@ | |||
|
|
|||
| from word_search import WordSearch, Point | |||
|
|
|||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 | |||
|
|
|||
There was a problem hiding this comment.
Minor formatting point, but can you move the version comment down a line (ie. two blank lines before, one after).
N-Parsons
suggested changes
Oct 26, 2017
- Move the version comment down a line
…thon into update/word-search
|
@N-Parsons I've resolved it. Thank you for pointing out my carelessness! |
N-Parsons
approved these changes
Oct 27, 2017
|
Perfect! Thanks, @wilson8507! I'm a bit picky about formatting and consistency 😛 |
josix
added a commit
to josix/python
that referenced
this pull request
Oct 28, 2017
) * word-search: Update tests to version 1.1.0(exercism#1012) * Remove redundant and misplaced assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue #1012