proverb: Update exercise to canonical-data 1.0.0 #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
N-Parsons
force-pushed
the
proverb-1.0.0
branch
from
ee259a6 to
bde4d7b
Compare
cmccandless
suggested changes
Nov 20, 2017
exercises/proverb/example.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| def proverb(itens, qualifier=''): | |||
| def proverb(items): | |||
There was a problem hiding this comment.
I like the name used in proverb.py. Can you change this to match for consistency?
N-Parsons
force-pushed
the
proverb-1.0.0
branch
from
bde4d7b to
c91e006
Compare
|
@cmccandless, thanks for pointing that out. |
cmccandless
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
proverbexercise to use the recently implemented canonical data.Note: there will be a merge conflict with #1113 due to changes in the README, but I will fix this when one of these PRs is merged.