fix deprecation warnings #1161
Merged
fix deprecation warnings #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Parsons
suggested changes
Jan 18, 2018
| @@ -82,9 +82,10 @@ def test_both_bases_are_negative(self): | |||
| # Utility functions | |||
| def setUp(self): | |||
| try: | |||
| self.assertRaisesRegex = self.assertRaisesRegexp | |||
| with self.assertRaisesRegex(AttributeError, r".+"): | |||
| raise AttributeError('x') | |||
There was a problem hiding this comment.
A cleaner solution is to just call self.assertRaisesRegex without actually using it.
try:
self.assertRaisesRegex
except AttributeError:
self.assertRaisesRegex = self.assertRaisesRegexp
N-Parsons
approved these changes
Jan 18, 2018
|
Thanks @cmccandless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In changes made in #1113, a convention was added to ensure that all exceptions raises by exercise solutions contained messages. The existing Python2/3 compatible solution was actually calling
assertRaisesRegexpin Python3, raisingDeprecationWarnings in the Travis-CI output for all Python3 builds. This PR fixes this, accomplishing the original intent to callassertRaisesRegexin Python3 andassertRaisesRegexpin Python2.