bowling: update tests to v1.2.0 #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, the example solution cannot pass added test cases. I will take some time to improve it. |
cmccandless
suggested changes
Feb 16, 2018
exercises/bowling/bowling_test.py
Outdated
|
|
||
| self.roll(rolls) | ||
|
|
||
| self.assertRaises(IndexError, self.game.roll, 2) |
There was a problem hiding this comment.
Please adopt the form used in #1182 for exceptions.
|
@cmccandless I've taken your work in #1182 into this PR. |
cmccandless
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1240
test_cannot_roll_after_bonus_roll_for_spareandtest_cannot_roll_after_bonus_rolls_for_strike, according to canonical data