twelve-days: re-implement according to canonical data #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Feb 19, 2018
| "a Partridge in a Pear Tree.\n\n" | ||
| class LyricsTests(unittest.TestCase): | ||
| def test_first_three_verses_of_the_song(self): | ||
| expected = ["On the first day of Christmas my true love gave to me, " |
There was a problem hiding this comment.
Since there are other tests verifying correct output from recite(n, n), I think the following would be adequate:
expected = [recite(n, n) for n in range(1, 4)]This also removes the need for large redundant text blocks.
There was a problem hiding this comment.
@cmccandless Pretty nice trick! But since recite returns a list of one string, we should capture its first element:
expected = [recite(n, n)[0] for n in range(1, 4)]There was a problem hiding this comment.
On the idea of nice tricks...
expected = sum([recite(n, n) for n in range(1, 4)], [])Not really any neater than what you're already doing, and it's not as readable, so please don't use that for this exercise.
| self.assertEqual(recite(1, 3), expected) | ||
|
|
||
| def test_three_verses_from_the_middle_of_the_song(self): | ||
| expected = ["On the fourth day of Christmas my true love gave to me, " |
There was a problem hiding this comment.
Again, expected = [recite(n, n) for n in range(4, 7)]
|
|
||
| def test_the_whole_song(self): | ||
| self.assertEqual(verses(1, 12), sing()) | ||
| expected = ["On the first day of Christmas my true love gave to me, " |
There was a problem hiding this comment.
Again, expected = [recite(n, n) for n in range(1, 13)]
cmccandless
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1221. Re-implement this exercise according to canonical data.