bracket-push: update tests to v1.2.0 #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Feb 19, 2018
| @@ -1,4 +1,4 @@ | |||
| def check_brackets(string): | |||
There was a problem hiding this comment.
I would like to see the parameter name match the one from the stub.
| @@ -1,2 +1,2 @@ | |||
| def check_brackets(input_string): | |||
There was a problem hiding this comment.
I think that input_string is more descriptive. To me, value is too generic. I would prefer that we leave this as-is.
Change both params to descriptive `input_string` in example and stub
mrcfps
force-pushed
the
bracket-push-1223
branch
from
fe1f32a to
8175c23
Compare
cmccandless
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1223. Canonical data.
Besides updating version number, I have renamed the function
check_bracketand its parameterinput_stringtois_pairedwith parametervalueto be consistent with canonical data.