Skip to content

Conversation

@cmccandless
Copy link
Contributor

Using the WIP extension instead of draft PR so that CI scripts will run on these changes.

@cmccandless cmccandless requested a review from a team as a code owner July 23, 2019 17:21
@cmccandless
Copy link
Contributor Author

Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're configuring flake to an 80 character limit we should do the same with black ... by default it's 88 characters and there will be occasional disconnect.

Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a sensible approach that will get us up and moving quick. I feel like my approach would play out better in the long run, but I'm willing to abandon it for now. Did suggest some small changes though.

@cmccandless
Copy link
Contributor Author

Since we're configuring flake to an 80 character limit we should do the same with black ... by default it's 88 characters and there will be occasional disconnect.

I followed black's recommendation on this; line length is still 80, but there's a tolerance of 10%.

Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is I'm happy to merge this and continue (though a few more docstrings would be nice).

@yawpitch
Copy link
Contributor

yawpitch commented Jul 24, 2019

I do think that a slight modification of my branches generate.py file could possibly be used to create a pretty good rough pass of the template text for quite a number of exercises, BTW.

Hmm ... actually maybe bypass that idea ... I don't see a foothold in jinja2 for getting the post-macro resolution, pre-render template.

@cmccandless
Copy link
Contributor Author

though a few more docstrings would be nice

Done.

Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmccandless cmccandless changed the title [WIP] Create test suite generator (requires per-exercise templates) Create test suite generator (requires per-exercise templates) Jul 24, 2019
@cmccandless cmccandless merged commit 380ae91 into exercism:master Jul 24, 2019
@cmccandless cmccandless deleted the generator-r2 branch July 24, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants