-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Create test suite generator (requires per-exercise templates) #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76593c9
to
ca972e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're configuring flake
to an 80 character limit we should do the same with black
... by default it's 88 characters and there will be occasional disconnect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a sensible approach that will get us up and moving quick. I feel like my approach would play out better in the long run, but I'm willing to abandon it for now. Did suggest some small changes though.
I followed |
Co-authored-by: Michael Morehouse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is I'm happy to merge this and continue (though a few more docstrings would be nice).
I do think that a slight modification of my branches generate.py file could possibly be used to create a pretty good rough pass of the template text for quite a number of exercises, BTW. Hmm ... actually maybe bypass that idea ... I don't see a foothold in jinja2 for getting the post-macro resolution, pre-render template. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Using the WIP extension instead of draft PR so that CI scripts will run on these changes.