Skip to content

Created LEARNING.md, TESTS.me and added some resources #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

oalbe
Copy link
Contributor

@oalbe oalbe commented Jan 24, 2016

Hey there,

Issue #280 and #279 stated the need for a LEARNING.md and a TESTS.md doc files. I created them and did my best with English, but I can't really guarantee zero grammar errors since I'm not a native.

I hope this will turn out to be useful.

@kytrinyx
Copy link
Member

This looks great. Would you mind checking what happened with the travis build? It seems unlikely that a documentation fix caused it to fail, but I'm not familiar with python. I kicked off the build again in case it was transient.

@oalbe
Copy link
Contributor Author

oalbe commented Jan 25, 2016

In fact from the logs it doesn't look like the documentation files are the problem. I'm not extremely familiar with Python either, but to me, it looks like the command

 flake8 . --ignore=E501

Returned a bunch of errors from five files. If you have the access to the Travis configuration for building, would you mind trying this command instead:

 flake8 . --ignore=E501,E731

This will also ignore the error that is being thrown 6 times from that files, though it would leave the warning alone. If it works, it should build without problems this time, and we can wait for someone who knows more about those things (like the track maintainer?) to definitely figure out and fix what happened.

I'm sorry but I wouldn't know how to help apart from this :/

@oalbe oalbe changed the title Created LEARNING.md and added some resources. Created LEARNING.md, TESTS.me and added some resources Jan 25, 2016
@kytrinyx
Copy link
Member

The build should be fixed if you want to rebase it onto master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants