limit line length to 79 chars

[rootulp]

No description provided.

[behrtam]

Just a small tip about our commit message style. The msg should start with the exercise name. https://github.com/exercism/xpython#pull-requests

I'm against pedantically keeping to the 79 limit. While it should definitely not exceed 120 characters, I favour readability over the 79-limit. In this case you split a lambda function because of 2 characters and #300, #301, #302 are equally unappealing to me.

[rootulp]

I think one should have very strong reasons to intentionally contradict PEP8, especially when the majority of the codebase conforms to these standards already. I support the 79 character limit for aesthetic viewing in vim splits. I also think that splitting up long lines aids in readability. In my opinion this:

+        self.assertEqual(inp, accumulate(accumulate(inp, lambda x:
+                         divmod(x, 7)), lambda x: 7 * x[0] + x[1]))

is more readable than this:

-        self.assertEqual(inp, accumulate(accumulate(inp, lambda x: divmod(x, 7)),
-                         lambda x: 7 * x[0] + x[1]))

especially in my editor (left split enforces 79 character limit, right split does not):

Having said that, I understand if you don't think the 79 character limit is necessary to enforce and I can close #299, #300, #301, #302. Also thanks for the heads up on commit message style. I'll try to conform to this in the future.

[behrtam]

First of all we are not really contradicting with PEP8.

Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the nominal line length from 80 to 100 characters (effectively increasing the maximum length to 99 characters), provided that comments and docstrings are still wrapped at 72 characters.

Right now the maximum line length we have is 92. So maybe we could set our limit to 99 and add this to hour flake8/travis-ci setup.

[kytrinyx]

I think that line length 99 sounds perfectly reasonable.

[rootulp]

For code maintained exclusively or primarily by a team that can reach agreement on this issue

I don't think we've reached agreement on this issue. I still think it makes sense to conform to the standards in PEP8 unless we have a strong reason not to. Also new contributors must learn that this project has extended the maximum line length from 79 characters to 99 characters. This means they must tune their editors, configure the style checks they run on code, etc.