Added default parameters to template functions #521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilislilit
changed the title
|
Thanks for your work but I think this should be done one PR per exercise, so we can have separate discussions about the names and follow our PR convention: https://github.com/exercism/python#pull-requests |
|
Yeah, sure, it could be done on one pr perexersize basis. |
|
I'm closing this one because we decided to add parameters in separate PRs for each exercise. @lilislilit, I hope you understand the reasoning behind this decision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing fix for #509 issue. Naming was taken from example.py files, mostly.