Skip to content

Pig Latin - Added Parameters to Placeholders #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Pig Latin - Added Parameters to Placeholders #592

merged 1 commit into from
Oct 4, 2017

Conversation

Sukhj1nder
Copy link
Contributor

@Sukhj1nder Sukhj1nder commented Oct 3, 2017

Added Parameters to the Pig Latin file in the function translate

This resolves the issue #592.
TODO: Pig Latin - Ticked on #509

Fixes #609

@ilya-khadykin ilya-khadykin merged commit eb34923 into exercism:master Oct 4, 2017
@ilya-khadykin
Copy link
Contributor

@Sukhj1nder congrats on your first merged PR! I hope it won't be the last 😀

I've corrected your commit message, here is a good guide of how to write good commit messages https://chris.beams.io/posts/git-commit/#seven-rules

Please also note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
It makes our work much easier. I hope this hint will help you to make your future PRs a bit better

@Sukhj1nder
Copy link
Contributor Author

@m-a-ge i'm very new to contributing to open-source project, this is actually my first contribution ever, it says that i can delete the branch. Should I?

@ilya-khadykin
Copy link
Contributor

@Sukhj1nder yeah, sure. It's an awesome feature of Github, it just removes the branch you've used for this PR (patch-5 in this case) from your fork.

@Sukhj1nder Sukhj1nder deleted the patch-5 branch October 4, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pig-latin: add parameters to exercise placeholder
2 participants