Skip to content

sublist: add parameters to exercise placeholder #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2017
Merged

sublist: add parameters to exercise placeholder #692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150629c
sublist: add parameters to exercise placeholder
anunciado Oct 3, 2017
0f580f8
sublist: change parameters names
anunciado Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/sublist/sublist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
def check_lists():
def check_lists(firstList, secondList):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python favors snake_case over CamelCase.
A good Python style guide from Google - https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

Could you please change it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this, I just started to using Python and I've never seen this guide before. So i just have to change firstList to first_list and secondList to second_list. Thanks for the guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cruxiu you're welcome

pass