Skip to content

sum-of-multiples: Add parameters to exercise placeholder for sum-of-multiples #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ackerleytng
Copy link
Contributor

@ackerleytng ackerleytng commented Oct 9, 2017

Working on #644 !

Fixes: #644

@ilya-khadykin ilya-khadykin changed the title [WIP] Add parameters to exercise placeholder for sum-of-multiples sum-of-multiples: Add parameters to exercise placeholder for sum-of-multiples Oct 9, 2017
@ilya-khadykin ilya-khadykin merged commit e21297e into exercism:master Oct 9, 2017
@ilya-khadykin
Copy link
Contributor

Thanks, @ackerleytng and congrats on your first PR ever 🥇

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
It makes our work much easier. I hope this hint will help you to make your future PRs a bit better

Just for future reference, a good guide of writing good commit messages https://chris.beams.io/posts/git-commit/#seven-rules

@ackerleytng
Copy link
Contributor Author

Thanks! :)

@ackerleytng ackerleytng deleted the sum-of-multiples-add-parameters branch October 9, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants